adminmpmcz/patchcenter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

fix(planning_import): RETURNING id au lieu de lastval() (FK violation patch_planning_import_rows_import_id_fkey)

Browse Source 
lastval() retourne la derniere valeur de sequence de la session — si un trigger sur
patch_planning_imports bumpe une autre sequence (ex: audit log), lastval() retourne
la mauvaise valeur. Resultat: import_id pointe vers un ID inexistant et les INSERT
sur patch_planning_import_rows echouent en FK violation.

Fix: INSERT ... RETURNING id qui est sans ambiguite, et early-return si NULL.
This commit is contained in:
Pierre & Lumière 2026-05-07 19:37:44 +02:00
parent 517b02f602
commit f539c604d6
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/routers/planning_import.py
View File

@ -490,13 +490,15 @@ async def import_upload(request: Request, db=Depends(get_db),
year_match = re.search(r"(20\d{2})", fname) year_match = re.search(r"(20\d{2})", fname)
year = int(year_match.group(1)) if year_match else None year = int(year_match.group(1)) if year_match else None
# Insert header # Insert header (RETURNING id : evite le bug lastval() pollué par triggers)
db.execute(text(""" import_id = db.execute(text("""
INSERT INTO patch_planning_imports (filename, year, sheet_count, row_count, uploaded_by, note) INSERT INTO patch_planning_imports (filename, year, sheet_count, row_count, uploaded_by, note)
VALUES (:fn, :y, 0, 0, :uid, :nt) VALUES (:fn, :y, 0, 0, :uid, :nt)
"""), {"fn": fname, "y": year, "uid": user.get("uid"), "nt": note or None}) RETURNING id
"""), {"fn": fname, "y": year, "uid": user.get("uid"), "nt": note or None}).scalar()
db.commit() db.commit()
import_id = db.execute(text("SELECT lastval()")).scalar() if not import_id:
return RedirectResponse(url="/patching/import?err=insert_header", status_code=303)
sheet_count = 0 sheet_count = 0
row_count = 0 row_count = 0